New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element.ShadowRoot
returns error when ShadowRoots
is empty
#788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test for it. Check the development guide for how to test the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the ci coverage error.
If you don't how please read: https://github.com/go-rod/rod/blob/master/.github/CONTRIBUTING.md
Head branch was pushed to by a user without write access
merging should close #787 |
Addresses #787
Development guide
Link
Test on local before making the PR